Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CakePHP 5.x compatibility #105

Open
asgraf opened this issue Jan 24, 2023 · 6 comments
Open

CakePHP 5.x compatibility #105

asgraf opened this issue Jan 24, 2023 · 6 comments

Comments

@asgraf
Copy link
Contributor

asgraf commented Jan 24, 2023

Are there any plans for CakePHP 5.x compatibility?

@ADmad
Copy link
Member

ADmad commented Jan 24, 2023

None currently. With the removal of ModelAwareTrait in Cake 5.x some major changes will be required to the plugin for 5.x compatibility. I haven't had the time to check / plan out what's required.

@AdrianHL
Copy link

Any plans to make this package compatible with CakePHP 5 once there is a stable version out?
Thanks in advance

@ADmad
Copy link
Member

ADmad commented Aug 17, 2023

I'll look into upgrading for Cake 5.x when I have some spare time but can't provide any time frame for it.

Someone from the community is welcome to provide a PR for the same. The ModelAwareTrait was finally retained for Cake 5 so that would the upgrade easier.

@JustinRuiter
Copy link

A PR was opened to resolve this issue: #107 . This PR is halfway there and the CI wasn't updated, along with some typing and implementation issues. I solved this in my PR: MolbioUnige#1 . Any feedback for this would be greatly appreciated.

@ADmad
Copy link
Member

ADmad commented Mar 28, 2024

@JustinRuiter You can open a new PR targeting the cake5 branch of this repo, or wait for MolbioUnige to merge your changes and update his PR.

@JustinRuiter
Copy link

#112

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants