Could it support custom compression ?

[ziiip]

Just like vite-plugin-string did?

[UstymUkhman]

Hi @ziiip and thanks for opening this issue. Yeah, I guess it would be pretty easy to implement. I can work on this when I'll have some time for this update. It's not a bad idea to use a custom compress function as an option, but can I ask you what have you found wrong with the current compress implementation?

I mean, I've test it quite a lot and if there's an issue with how it works, I would much prefer fixing it before updating the compress option to use a custom algorithm. Thanks again for your feedback and please consider ⭐ing this plugin if you've found it any useful for your purposes.

[ziiip]

It worth ⭐, I just forget it.

Actually, I was using Webpack in previous project, and webpack-glsl-minify's minifying seems to be more suitable for me, like c or c++ style comments removing, name mangling (not using it yet). preprocessPass1 and preprocessPass2 are the main minifying code.

This plugin is really useful, especially with Three.js, and I think it could be better with a little enhancement in minifying.

Thanks for the consideration.

[UstymUkhman]

Thank you for the explanation and for using it. That totally makes sense. I will add that option, just can't tell you exactly when (maybe this weekend..?) 🙂

[ziiip]

As you wish. I am glad that you are going to work on it.
Since I am trapped by many things these days, or I will make a PR with that.

Should I close this issue now, or leave it util you finished?

[UstymUkhman]

Naah, I'll close it once I'll publish a new version on NPM.

[UstymUkhman]

Closing this since v0.5.4 was published with an option to use a custom compress callback.