Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VapourSynth: missing calls to VSAPI::setError #54

Open
dubhater opened this issue Apr 26, 2016 · 0 comments
Open

VapourSynth: missing calls to VSAPI::setError #54

dubhater opened this issue Apr 26, 2016 · 0 comments

Comments

@dubhater
Copy link

vapoursynth/vapoursynth#226

It looks like you return from vs_lwlibavsource_create without calling createFilter and without calling setError. Please always call setError when there is an error. I was going to list all the places where you're not calling it, but there are over 9000 layers and places where you may or may not have called it, and I can't tell anymore.

Bonus: these are not necessary:

propGetData will not fail because the "source" parameter is not optional. Its presence is checked before vs_lwlibavsource_create or vs_libavsmashsource_create are called.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant