Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Поддержать getRootRef на всех компонентах #1733

Closed
thoughtspile opened this issue Jul 14, 2021 · 0 comments · Fixed by #5651
Closed

[Bug] Поддержать getRootRef на всех компонентах #1733

thoughtspile opened this issue Jul 14, 2021 · 0 comments · Fixed by #5651
Assignees
Milestone

Comments

@thoughtspile
Copy link
Contributor

Сейчас getRootRef поддерживается не на всех компонентах. Проблемы:

  1. Компоненты, которые прокидывают getRootRef на children (да, Tooltip) или поддерживают Component поддерживают не все VKUI-компоненты. Например, <Tooltip><Cell /></Tooltip> не сработает.
  2. Мы будем всегда получать фича-реквесты на поддержу getRootRef

Предлагаю сразу поддержать getRootRef на всех компонентах и проконтролировать это тестами / абстракцией

@SevereCloud SevereCloud moved this to Backlog in VKUI Aug 1, 2022
@SevereCloud SevereCloud added this to VKUI Aug 1, 2022
@SevereCloud SevereCloud self-assigned this Aug 18, 2023
@SevereCloud SevereCloud moved this from 🗃 Backlog to 🔧 In progress in VKUI Aug 18, 2023
@SevereCloud SevereCloud moved this from 🔧 In progress to 👀 In Review in VKUI Aug 21, 2023
@SevereCloud SevereCloud added this to the v5.8.0 milestone Aug 22, 2023
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in VKUI Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants