Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v5][Bug]: Не прокидывается ref в тултип #6216

Closed
pekanboy opened this issue Dec 6, 2023 · 2 comments · Fixed by #6484
Closed

[v5][Bug]: Не прокидывается ref в тултип #6216

pekanboy opened this issue Dec 6, 2023 · 2 comments · Fixed by #6484
Assignees
@mendrew
Labels
cmp:tooltip type:bug
Milestone
v5.10.1

Comments

@pekanboy
Copy link

pekanboy commented Dec 6, 2023 •
edited
Loading

Описание

https://github.com/VKCOM/VKUI/blob/master/packages/vkui/src/components/Tooltip/Tooltip.tsx#L284

Привет! Поправьте пожалуйста!
В компонент Tooltip вы даете возможность передавать getRootRef, но при это в самом компоненте его перебиваете своим getRootRef
Добавьте мердж рефов в этом случае, пожалуйста

Версия

5.9.10 (на данный момент latest)

В каких браузерах воспроизводится проблема?

No response

Шаги воспроизведения

No response

Ожидаемое поведение

No response

Скриншоты

No response

Пример с воспроизведением

No response
@pekanboy pekanboy changed the title [Bug]: [Bug]: Не прокидывается ref в тултип Dec 6, 2023
@mendrew mendrew added this to VKUI Dec 6, 2023
@github-project-automation github-project-automation bot moved this to 🗃 Backlog in VKUI Dec 6, 2023
@mendrew mendrew moved this from 🗃 Backlog to 🔜 To do in VKUI Dec 6, 2023
@mendrew mendrew self-assigned this Dec 6, 2023
@mendrew mendrew mentioned this issue Jan 29, 2024
Merged
1 task
@mendrew mendrew moved this from 🔜 To do to 🔧 In progress in VKUI Jan 29, 2024
@mendrew mendrew moved this from 🔧 In progress to 👀 In Review in VKUI Jan 29, 2024
@inomdzhon inomdzhon added this to the v5.10.1 milestone Jan 29, 2024
@mendrew mendrew linked a pull request Jan 30, 2024 that will close this issue
fix(Tooltip): Merge getRootRef prop with floating ref and pass to BaseTooltip getRootRef #6484
Merged
1 task
@mendrew mendrew moved this from 👀 In Review to ✅ Done in VKUI Jan 30, 2024
@mendrew
Copy link
Contributor

mendrew commented Feb 8, 2024

Поправлено в #6484 будет выпущено в версии v5.10.1 в скором времени.

@mendrew mendrew closed this as completed Feb 8, 2024
@inomdzhon inomdzhon changed the title [Bug]: Не прокидывается ref в тултип [v5][Bug]: Не прокидывается ref в тултип Feb 28, 2024
@inomdzhon inomdzhon removed the v5.10.1 label Feb 28, 2024
@vkcom-publisher
Copy link
Contributor

✅ v5.10.1 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mendrew mendrew

Labels
cmp:tooltip type:bug
Projects
VKUI
Archived in project
Milestone
v5.10.1
Development

Successfully merging a pull request may close this issue.

fix(Tooltip): Merge getRootRef prop with floating ref and pass to BaseTooltip getRootRef VKCOM/VKUI
4 participants
@mendrew @inomdzhon @pekanboy @vkcom-publisher