Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

va{ & va} doesn't select closing brace #1023

Closed
jeffschwartz opened this issue Nov 1, 2016 · 6 comments
Closed

va{ & va} doesn't select closing brace #1023

jeffschwartz opened this issue Nov 1, 2016 · 6 comments

Comments

@jeffschwartz
Copy link

What did you do?

In normal mode I entered va{.

What did you expect to happen?

Both opening and closing braces along with enclosed content to be selected.

What happened instead?

The enclosed content and only the opening brace was selected. The closing brace was not selected.

Technical details:

  • VSCode Version: 1.6.1
  • VsCodeVim Version: 0.4.1
  • OS: Mac OS X 10.9.5

Cursor within enclosing braces and then keying va{:
screen shot 2016-11-01 at 9 14 01 am

Result of keying va{. Note that only the opening brace was selected along with the enclosed content, and that the closing brace was not selected:
screen shot 2016-11-01 at 9 14 25 am

@jeffschwartz
Copy link
Author

Has someone looked into this yet? It is a trifle but very annoying bug.

@xconverge
Copy link
Member

I was able to reproduce it, it is strange because it works in some cases

{
test
test}

works but

{
test
test
}

does not

@xconverge
Copy link
Member

this was caused by #1014

also relates to #1022

The way our visual cursor works is annoying here, should be able to find something that works for all of these cases though

@jeffschwartz
Copy link
Author

jeffschwartz commented Nov 17, 2016

This is still broken with v0.4.2. Entering va{ from within the content of the CSS rule omits the selection of the ending brace and results in the following:

`screen shot 2016-11-17 at 9 56 02 am

@jeffschwartz
Copy link
Author

Just to confirm, it works now yeah LOL. Thank you to all the maintainers and contributors to this project. Outstanding!!!

@xconverge
Copy link
Member

No problem @jeffschwartz, feel free to continue to report what you find! We are looking for stability and every little bit helps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants