Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gb command is buggy & ignores letter case #1546

Open
baltuonis opened this issue Apr 21, 2017 · 4 comments
Open

gb command is buggy & ignores letter case #1546

baltuonis opened this issue Apr 21, 2017 · 4 comments
Labels

Comments

@baltuonis
Copy link

baltuonis commented Apr 21, 2017

  • Click thumbs-up 👍 on this issue if you want it!
  • Click confused 😕 on this issue if not having it makes VSCodeVim unusable.

The VSCodeVim team prioritizes issues based on reaction count.


What did you do?

Let's say I have this code:

  images: images[0],
  imAge: image,
  selectedImage: images.selectedImage,

My cursor is on images
And I use gb

What did you expect to happen?

I expected that it would step by step select all 3 occurences of images in my code

What happened instead?

It selected image, (yes! comma too)
It also ignores letter case (ignorecase is false) so it selects imAge: Image: etc...

Technical details:

  • VSCode Version:
    Version 1.11.1
    Commit d9484d12b38879b7f4cdd1150efeb2fd2c1fbf39
    Date 2017-04-06T13:58:12.954Z
    Shell 1.4.6
    Renderer 53.0.2785.143
    Node 6.5.0

  • VsCodeVim Version: v0.6.17

  • OS: Windows 10 Home 64bit

@baltuonis baltuonis changed the title gc command ignores letter case gc command is buggy & ignores letter case Apr 21, 2017
@xconverge
Copy link
Member

duplicate of #1160 I don't think that one should have been closed

This has to do with how we handle selection vs vscode

@johnfn
Copy link
Member

johnfn commented Apr 21, 2017

This doesn't look like a duplicate of #1160 to me. #1160 is because of the last-character thing. This seems to be a case sensitivity issue.

I actually don't understand this one, since we just directly use the vscode command...

https://github.com/VSCodeVim/Vim/blob/master/src/actions/actions.ts#L6324

@xconverge
Copy link
Member

I see but image, being selected is the same problem

@cobbweb
Copy link
Contributor

cobbweb commented Apr 22, 2017

The case-sensitivity of cmd+d in VSCode (and therefore gb too I'm guessing) is controlled by the toggle in the Find UI (cmd+f).

@Chillee Chillee changed the title gc command is buggy & ignores letter case gb command is buggy & ignores letter case May 30, 2017
@J-Fields J-Fields changed the title gb command is buggy & ignores letter case gb command is buggy & ignores letter case Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants