Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding configs for statusBarColorControl and statusBarColors existing workbench.colorCustomizations settings are removed #2150

Closed
thousand opened this issue Nov 15, 2017 · 2 comments

Comments

@thousand
Copy link

BUG REPORT:

Environment:

  • VSCode Version: 1.18.0
  • VsCodeVim Version: 0.10.4
  • OS: macOS 10.12.6

What happened:

I enabled the "vim.statusBarColorControl" user preference and added some "vim.statusBarColors" configs. Doing this wiped out my workbench.colorCustomizations for the cursor color.

pre-existing customization:

"workbench.colorCustomizations": {
  "editorCursor.background": "#ff00ff"
}

added for vim:

  "vim.statusBarColorControl": true,
  "vim.statusBarColors": {
    "normal": "#444444",
    "insert": "#226622",
    "visual": "#224466",
    "visualline": "#662244",
    "visualblock": "#224466",
    "replace": "#662222"
  }

new workbench.colorCustomizations:

  "workbench.colorCustomizations": {
    "statusBar.background": "#224466",
    "statusBar.noFolderBackground": "#224466",
    "statusBar.debuggingBackground": "#224466"
  },

What did you expect to happen:
I would expect this to merge the status bar colors into the other color customization settings instead of replacing them.

How to reproduce it:
(see above)

@jpoon
Copy link
Member

jpoon commented Nov 15, 2017

Sounds like a dupe of #1654

@jpoon
Copy link
Member

jpoon commented Nov 16, 2017

Fixed with #2122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants