Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"S" (capital s) does not behave properly when on prefixing whitespace #2240

Closed
avegancafe opened this issue Dec 23, 2017 · 4 comments
Closed

Comments

@avegancafe
Copy link

avegancafe commented Dec 23, 2017

  • Click thumbs-up 👍 on this issue if you want it!
  • Click confused 😕 on this issue if not having it makes VSCodeVim unusable.

The VSCodeVim team prioritizes issues based on reaction count.


Is this a BUG REPORT or FEATURE REQUEST? (choose one):

This is a bug report
Environment:

  • VSCode Version: 1.19.1
  • VsCodeVim Version: 0.10.6
  • OS: macOS

What happened:

In vim when you click S (capital s) in normal mode, it should clear the line and place your character into insert mode at the appropriate indentation level. This works properly when you click S somewhere in the middle of the line, but if you click S anywhere inside of the prefixing whitespace of a line, it does not go to the proper indentation level. Here's an example:

const a = {
  b: 10,
| c: 40
}

Say my cursor is where that | is (that's not an actual character, I just wanted to represent the cursor). If you click S, it should clear that line and place you in insert mode at indentation level 1, however what happens currently in VSCodeVim is it will clear the line and go into insert mode, however not go to the appropriate indentation level. If my cursor is say, on the 4 instead of on the |, when you click S it will indeed clear everything from c onwards and put you into insert mode at the correct indentation level, however.

P.S. Sorry if this is a duplicate of another issue! It was relatively difficult to search through the others, as I can't simply just search for S 😂

@aldanor
Copy link

aldanor commented Jun 7, 2018

Are there any updates to this? We can't be the only two who noticed it...

@avegancafe
Copy link
Author

You'd think so, I'm surprised more people aren't bothered by this

@avegancafe
Copy link
Author

@aldanor this has recently started working for me, not sure what change went through that fixed this. Wanna confirm that this is fixed for you too and we can close this? 🎉

@avegancafe
Copy link
Author

Looks like it was in this commit 32e61212. Closing! 🎉 🎆 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants