Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.10.10 Crtl+d not work any more #2292

Closed
shpontex opened this issue Jan 16, 2018 · 10 comments
Closed

v0.10.10 Crtl+d not work any more #2292

shpontex opened this issue Jan 16, 2018 · 10 comments

Comments

@shpontex
Copy link

Crtl+d not work any more

  • Extension (VsCodeVim) version: 0.10.10
  • VSCode version: 1.19.2
  • OS version: High sierra 10.13.2
@pablopunk
Copy link

Same here!

@fairyhunter13
Copy link

fairyhunter13 commented Jan 16, 2018

I don't know why Ctrl+d just change --NORMAL-- to --VISUAL-- in my editor. It seems from my assumption that this key is not referring to scrolling of page, instead it refers to multi-cursor mode.

Extension (VsCodeVim) version: 0.10.10
VSCode version: 1.19.2
OS version: Windows 10 x64bit Professional

*Solved: By disabling auto update in extensions and install vscodevim plugin manually to v0.10.9 using vsix (downgrading).

@Nodman
Copy link
Contributor

Nodman commented Jan 16, 2018

Handler for was refactored a bit in #2269.
To bring back old behavior, for now, add to settings:

"vim.handleKeys": {
    "<C-d>": true,
  },

@Nodman
Copy link
Contributor

Nodman commented Jan 16, 2018

Feels like there is extra negate operator in condition in src/mode:292

if (key === '<C-d>' && !(Configuration.handleKeys['<C-d>'] === true)) {

@jpoon
Copy link
Member

jpoon commented Jan 16, 2018

This is by-design. It was to fix this issue #2162. tldr; 3 different behaviours can be controlled by <C-d>, and this PR #2269 in the lastest release changes it to what we felt was a bit more sane:

useCtrlKeys = true useCtrlKeys = false
handleKeys = true VSCodeVim move page half down VSCodeVim move page half down
handleKeys = false remap to <D-d> remap to <D-d>
undefined VS Code default behavior VS Code default behavior

Essentially, the useCtrlKeys is not longer taken into account for <C-d>. Personally, I'd like to remove useCtrlKeys in a later release as the functionality can also be configured with handleKeys.

Apologies for not following semvar semantics, should have bumped up the minor as it sorta breaks people's settings.

@typeoneerror
Copy link

typeoneerror commented Jan 16, 2018

@jpoon thanks for the explainer! I don't think following semver fixes vsix autoUpdating though, so no need to apologize. VS Code needs a rethink for being able to specify versioning per extension, I think, so this wasn't really the extension's bad. Patch or minor, a note in release notes about what user's need to change to adopt would be the best route for now. Thanks again for your work!

@jpoon
Copy link
Member

jpoon commented Jan 16, 2018

Patch or minor, a note in release notes about what user's need to change to adopt would be the best route for now.

With semvar notation, if users see a major/minor release there should know there could be some breaking changes. Yeah, should have added this to the release notes. If you know any good tooling to generate changelogs/release notes please share.

@jpoon
Copy link
Member

jpoon commented Jan 18, 2018

I'm going to push an update adding this to the release notes. It includes another fix with macros + status bar, but the update is really about messaging this change with <C-d>

@scottlu
Copy link

scottlu commented Jan 20, 2018

Not to belabor this topic but shouldn't handleKeys C-d be the default? I think this is what most vim users would expect.

@Graham42
Copy link
Contributor

@scottlu I've opened a PR for this here #2314

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants