Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Option 'vim.showcmd' has no effect #2365

Closed
IsaacKhor opened this issue Feb 6, 2018 · 8 comments
Closed

[Bug] Option 'vim.showcmd' has no effect #2365

IsaacKhor opened this issue Feb 6, 2018 · 8 comments
Labels

Comments

@IsaacKhor
Copy link

Is this a BUG REPORT or FEATURE REQUEST? (choose one): Bug report

What happened: When vim.showcmd is set to true, implicitly or explicitly, commands being written are not shown

What did you expect to happen: Incomplete commands shoud be shown on the status bar

How to reproduce it (as minimally and precisely as possible):

  • Start new VSCode instance with fresh config
  • Install VSCodeVim
  • Open any file
  • Type 20 or c
  • Expected behaviour: the characters 20 or c shown in status bar
  • Actual behaviour: status bar does not change

Environment:

  • Extension Name: vim
  • Extension Version: 0.10.13
  • OS Version: Darwin x64 17.3.0
  • VSCode version: 1.19.3

We have written the needed data into your clipboard. Please paste:

{
	"activationTimes": {
		"startup": true,
		"codeLoadingTime": 211,
		"activateCallTime": 2,
		"activateResolvedTime": 0,
		"activationEvent": "*"
	},
	"runtimeErrors": [
		{
			"name": "TypeError",
			"message": "Cannot read property 'document' of undefined"
		},
		{
			"name": "TypeError",
			"message": "Cannot read property 'document' of undefined"
		},
		{
			"name": "TypeError",
			"message": "Cannot read property 'document' of undefined"
		},
		{
			"name": "TypeError",
			"message": "Cannot read property 'document' of undefined"
		},
		{
			"name": "TypeError",
			"message": "Cannot read property 'document' of undefined"
		},
		{
			"name": "TypeError",
			"message": "Cannot read property 'document' of undefined"
		},
		{
			"name": "TypeError",
			"message": "Cannot read property 'document' of undefined"
		},
		{
			"name": "TypeError",
			"message": "Cannot read property 'document' of undefined"
		},
		{
			"name": "TypeError",
			"message": "Cannot read property 'document' of undefined"
		},
		{
			"name": "TypeError",
			"message": "Cannot read property 'document' of undefined"
		},
		{
			"name": "TypeError",
			"message": "Cannot read property 'document' of undefined"
		},
		{
			"name": "TypeError",
			"message": "Cannot read property 'document' of undefined"
		},
		{
			"name": "TypeError",
			"message": "Cannot read property 'document' of undefined"
		}
	]
}
@jpoon
Copy link
Member

jpoon commented Feb 6, 2018

Damn, so many special cases of when/when not to update the status bar. I can repro, should be able to fix this soon.

@jpoon jpoon added the kind/bug label Feb 6, 2018
@Dvbnhbq
Copy link

Dvbnhbq commented Feb 14, 2018

I'm experiencing the same issue. "vim.showcmd": true doesn't effect. How such bugs are possible? Do you guys have some testers in there? The way you do things is so annoying, first you publish a buggy product, then fix the bugs... Can I just have a complete working product at the same time? Status bar behavior, is it a big deal?

As an addition, vim.showmodename option works incorrectly, it doesn't show the mode name immediately after file was saved and until mode is changed to INSERT mode.

@jpoon
Copy link
Member

jpoon commented Feb 15, 2018

@Dvbnhbq, I understand your frustration. However, do realize that we are a community of volunteers. Nobody is paid to maintain this extension, to fix bugs, or to add features. Please see our Code of Conduct for more details.

All the source code is available here on GitHub, so if you see a bug that is frustrating you, I encourage you to help fix it. As mentioned above, the fix for this is pretty simple so it'd be a good bug to take on for any first-time contributors.

As an addition, vim.showmodename option works incorrectly, it doesn't show the mode name immediately after file was saved and until mode is changed to INSERT mode.

This is similar to how vanilla VIM is implemented. Please file a separate issue if you think otherwise.

@jpoon
Copy link
Member

jpoon commented Feb 15, 2018

I've taken a break from my vacation to fix this: #2386.

@Dvbnhbq
Copy link

Dvbnhbq commented Feb 18, 2018

@jpoon Hey! Sorry, I was not right saying that. I was like this is all Microsoft software...I'm really disappointed by them. I didn't realize that this is from volunteers. Once again, sorry for that.
And thanks for your fix. Hope this works.

@Chillee
Copy link
Member

Chillee commented Feb 19, 2018

@Dvbnhbq Although some of the people who've contributed to this extension are Microsoft employees, many are not. For example, I'm just a college student who contributes to this extension in between managing courses, research, and other extracurriculars.

@jpoon
Copy link
Member

jpoon commented Feb 19, 2018

Disclaimer: I am a Microsoft employee, but I do this in my off-time. @Dvbnhbq I'm curious what your experience with these other "buggy" Microsoft products you mentioned. A lot of the teams are now using GitHub to track issues, but if you have come across a specific issue I can see if I can track down the owner within the company.

@jpoon
Copy link
Member

jpoon commented Feb 19, 2018

Closed with #2386

@jpoon jpoon closed this as completed Feb 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants