Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:on is not an editor command #3286

Closed
sw9 opened this issue Dec 22, 2018 · 4 comments
Closed

:on is not an editor command #3286

sw9 opened this issue Dec 22, 2018 · 4 comments

Comments

@sw9
Copy link

sw9 commented Dec 22, 2018

Describe the bug
:on is not an editor command

To Reproduce

  1. be in normal mode
  2. type :vsp to split the screen
  3. type :on to remove the split
  4. see message :on is not an editor command

Expected behavior
All other splits are closed

Environment (please complete the following information):

  • Extension Version: 0.17.0
  • OS Version: Windows_NT x64 10.0.17134
  • VSCode version: 1.30.1
@jpoon
Copy link
Member

jpoon commented Dec 23, 2018

Interesting, didn't know of this command. From vim help:

CTRL-W CTRL-O					*CTRL-W_CTRL-O* *:on* *:only*
		Make the current window the only one on the screen.  All other
		windows are closed.  For {count} see |:quit| command.
		
		When the 'hidden' option is set, all buffers in closed windows
		become hidden.
		
		When 'hidden' is not set, and the 'autowrite' option is set,
		modified buffers are written.  Otherwise, windows that have
		buffers that are modified are not removed, unless the [!] is
		given, then they become hidden.  But modified buffers are
		never abandoned, so changes cannot get lost.

@aquova
Copy link
Contributor

aquova commented Dec 28, 2018

To elaborate, the :on command is a shortened alias for :only, which is properly implemented in VSCode Vim. It's simply the shortened command that isn't recognized.

@jpoon
Copy link
Member

jpoon commented Dec 29, 2018

@aquova ah, nice. as we already have that implemented, super easy to add alias.

@xconverge
Copy link
Member

fixed in #3303

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants