Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After the VSCode 1.36 update, some leader+key+key combinations won't work. #3883

Closed
Peluko opened this issue Jul 10, 2019 · 4 comments
Closed

Comments

@Peluko
Copy link

Peluko commented Jul 10, 2019

Describe the bug
After the VSCode 1.36 update, some leader+key+key combinations won't work. For example, the settings:

    "vim.normalModeKeyBindingsNonRecursive": [
        {
            "before": [
                "<leader>",
                "b",
                "b"
            ],
            "after": [],
            "commands": [
                {
                    "command": "workbench.action.showAllEditors",
                    "args": []
                }
            ]
        },
    ],

won't work, although

    "vim.normalModeKeyBindingsNonRecursive": [
        {
            "before": [
                "<leader>",
                "b"
            ],
            "after": [],
            "commands": [
                {
                    "command": "workbench.action.showAllEditors",
                    "args": []
                }
            ]
        },
    ],

Works flawlessly and

    "vim.normalModeKeyBindingsNonRecursive": [
        {
            "before": [
                "<leader>",
                "p",
                "b"
            ],
            "after": [],
            "commands": [
                {
                    "command": "workbench.action.showAllEditors",
                    "args": []
                }
            ]
        },
    ],

also works. It only happens with some leader plus two keys combinations. For example, any leader+b+key or leader+e+key combinations won't work, but leader+p+key or leader+t+key works perfectly.

  • Extension (VsCodeVim) version: 1.8.1
  • VSCode version: 1.36.1
  • OS: Windows 10
@tjstankus
Copy link

tjstankus commented Jul 17, 2019

These two key bindings (at least) are no longer working for me:

"vim.normalModeKeyBindingsNonRecursive": [
        {
            "before":["leader", "s", "c"],
            "after":[],
            "commands": [
                {
                    "command": ":nohl",
                    "args": []
                }
            ]
        },
        {
            "before": ["leader", "f", "s"],
            "after": [],
            "commands": [
                {
                    "command": "workbench.action.files.save",
                    "args": []
                }
            ]
        }
]

VSCodeVim: 1.8.2
VSCode: 1.36.1
MacOS: 10.14.5

@tjstankus
Copy link

Update to above comment. They are working now. If I run across the issue again, I'll try to debug and provide more details.

Are they still not working for you @Peluko?

@Peluko
Copy link
Author

Peluko commented Aug 2, 2019

Hello. I've been some days on vacation. I've detected that this issue is only present when vim.camelCaseMotion.enable is true. When it's set to false, the key combo works perfectly.

@Peluko
Copy link
Author

Peluko commented Aug 21, 2020

Duplicate of #4563

@Peluko Peluko closed this as completed Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants