Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing support for "change inside" and "delete inside" #443

Closed
ascandella opened this issue Jul 14, 2016 · 4 comments
Closed

Missing support for "change inside" and "delete inside" #443

ascandella opened this issue Jul 14, 2016 · 4 comments

Comments

@ascandella
Copy link
Contributor

First off, congrats on the progress with the plugin, given recent progress I'm finally able to use it for my day-to-day work.

I was looking at the Roadmap to try to figure out whether this was planned or not, but I don't see any mention of it. I'd like to figure out whether it's already planned or impossible with the current VSCode APIs. If it's possible, I'm interested in implementing it myself.

The most common ones I'm used to are ci(, ci", ciw, and their "di" variants.

@ascandella
Copy link
Contributor Author

Note: there is currently support for "viw" and "vaw" for visual selection (but no vi( or 'vi"`), but those are the only mention of commands that behave like this as far as I can tell.

@johnfn
Copy link
Member

johnfn commented Jul 14, 2016

Yay! Glad to hear it.

We have a mega-issue for this open here: #287

If you do want to take a whack at one of these, by all means go ahead! I'd suggest to make a separate issue for it, and tag it with 'in-progress' so that no one else implements it at the same time.

@johnfn johnfn closed this as completed Jul 14, 2016
@ascandella
Copy link
Contributor Author

Sounds great. Tedious but easy sounds like a good place to start given that I'm new to the codebase and TypeScript (although I've done some node previously).

@johnfn
Copy link
Member

johnfn commented Jul 14, 2016

Awesome! Feel free to hang out on slack if you want to ask me questions or something.

We already have % which is good at finding matching delimiters, so that will be a good place to start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants