Shift+S doesn't add indentation

[mnsr]

• VSCode Version: 1.4.0
• VsCodeVim Version: latest
• OS: Win10

The implementation of Shift+S doesn't match standard VIM.

Shift+S is supposed to:

1. Clear entire line under cursor
2. Add indentation
3. Switch to insert mode.

Currently, vscodevim doesn't do #2.

So if if i'm inside a function like this:

function Test() {
  var greeting = "hello";
// << Shift+S should put the correct indentation here (2 spaces) and switch to insert mode
}

[johnfn]

Keep in mind that this has to respect the users settings, as the user can turn off indentation and then it won't indent. We were holding off on it before because we didn't have setting integration - now, thanks to @rebornix, we do!

[ascandella]

FWIW I believe this should also happen for cc (it auto-indents in evil-mode in emacs as well as a bare vim with :set autoindent)

[ascandella]

@johnfn can you clarify the user prefs part? Are you suggesting adding an additional user preference to enable/disable auto-indentaion, or that there already is a setting that we should respect?

EDIT: I see what you mean. Something like Configuration.getInstance().autoindent. Question for @rebornix -- I assume most people will want autoindent to be "on by default". What are the semantics around settings for those? Should we just check for noautoindent?