Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load and map files with its respectives libraries from a csv description #348

Closed
davidmedinasigasi opened this issue Jun 25, 2018 · 6 comments

Comments

@davidmedinasigasi
Copy link
Contributor

Maybe the first version of the Vunit integration with Sigasi will use this feature but we may change it in the future.

@kraigher
Copy link
Collaborator

Why is this necessary. VUnit already has a Python-API to add files and libraries? Any user can add a .csv reader on top of this if they need to have one.

@lievenlemiengre
Copy link

This api takes away a sore point to achieve integration with tools: managing the list of files provided by the user. If you think there is an easy way to get the same result, feel free to share your ideas. If you want good tool support there will be some inevitable impact on your api.

The only alternative that I see is a separate module (for example vunit-sigasi) with the csv parser. The user would have to install another module, add an import to their vunit file & importing the csv file would be slightly uglier. We can do it but I think this will give the end-user a better experience while the impact on your api is minimal. We're willing to contribute the code & tests.

@kraigher
Copy link
Collaborator

I do not mind merging support for reading a list of files from CSV. I just ask why it is necessary for your use case to understand what your big picture is. Based on your answer I infer that you want this feature to be used by the end user whereas I first thought it was just about privately exchanging files between tools for which the Python API could be used without any additions.

@qarlosalberto
Copy link

It would be interesting if Sigasi open sourced the code that interacts with VUnit :)

@lievenlemiengre
Copy link

It would be interesting if Sigasi open sourced the code that interacts with VUnit :)

We thought about this but it looks like we'll depend on a lot of internal API that may break on every Sigasi release. It's still likely that we'll open source parts of it. The com.sigasi.hdt.epl and com.sigasi.hdt.epl.ui plugins are shipped with source but they don't have a public repo.

@kraigher
Copy link
Collaborator

kraigher commented Sep 1, 2018

This is already implemented.

@kraigher kraigher closed this as completed Sep 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants