Skip to content

Commit

Permalink
fix(remember volumes): being exported as [object Object]
Browse files Browse the repository at this point in the history
Closes #117
  • Loading branch information
VampireChicken12 committed Nov 25, 2023
1 parent 70f4ae5 commit 418d3f9
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 13 deletions.
11 changes: 4 additions & 7 deletions src/pages/inject/index.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import type { AvailableLocales } from "@/src/i18n";
import type { ContentSendOnlyMessageMappings, Messages, StorageChanges, configuration, configurationKeys } from "@/src/types";
import type { ContentSendOnlyMessageMappings, Messages, RememberedVolumes, StorageChanges, configuration, configurationKeys } from "@/src/types";

import { getVideoHistory, setVideoHistory } from "@/src/features/videoHistory/utils";
import { defaultConfiguration } from "@/src/utils/constants";
Expand Down Expand Up @@ -108,12 +108,9 @@ document.addEventListener("yte-message-from-youtube", () => {
break;
}
case "setRememberedVolume": {
/**
* Sets the remembered volume in the local storage.
*
* @type {number}
*/
void chrome.storage.local.set({ remembered_volumes: JSON.stringify({ ...message.data }) });
const { remembered_volumes: existingRememberedVolumeStringified } = await chrome.storage.local.get("remembered_volumes");
const existingRememberedVolumes = parseStoredValue(existingRememberedVolumeStringified as string) as RememberedVolumes;
void chrome.storage.local.set({ remembered_volumes: JSON.stringify({ ...existingRememberedVolumes, ...message.data }) });
break;
}
case "extensionURL": {
Expand Down
9 changes: 3 additions & 6 deletions src/types/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export const screenshotFormat = ["png", "jpg", "webp"] as const;
export type ScreenshotFormat = (typeof screenshotFormat)[number];
export const modifierKey = ["altKey", "ctrlKey", "shiftKey"] as const;
export type ModifierKey = (typeof modifierKey)[number];

export type RememberedVolumes = { shortsPageVolume?: number; watchPageVolume?: number };
export type configuration = {
enable_automatic_theater_mode: boolean;
enable_automatically_set_quality: boolean;
Expand All @@ -62,10 +62,7 @@ export type configuration = {
osd_display_type: OnScreenDisplayType;
player_quality: YoutubePlayerQualityLevel;
player_speed: number;
remembered_volumes: {
shortsPageVolume?: number;
watchPageVolume?: number;
};
remembered_volumes: RememberedVolumes;
screenshot_format: ScreenshotFormat;
screenshot_save_as: ScreenshotType;
scroll_wheel_volume_control_modifier_key: ModifierKey;
Expand Down Expand Up @@ -109,7 +106,7 @@ export type RequestDataMessage<Type extends string, D> = Prettify<
>;
export type ContentSendOnlyMessageMappings = {
pageLoaded: SendDataMessage<"send_data", "content", "pageLoaded", undefined>;
setRememberedVolume: SendDataMessage<"send_data", "content", "setRememberedVolume", { shortsPageVolume?: number; watchPageVolume?: number }>;
setRememberedVolume: SendDataMessage<"send_data", "content", "setRememberedVolume", RememberedVolumes>;
};
export type ExtensionSendOnlyMessageMappings = {
automaticTheaterModeChange: DataResponseMessage<"automaticTheaterModeChange", { automaticTheaterModeEnabled: boolean }>;
Expand Down

0 comments on commit 418d3f9

Please sign in to comment.