Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Add Open Transcript button in Feature Menu #164

Closed
lamyergeier opened this issue Dec 10, 2023 · 10 comments
Closed

Feature Request: Add Open Transcript button in Feature Menu #164

lamyergeier opened this issue Dec 10, 2023 · 10 comments
Assignees
@VampireChicken12
Labels
enhancement New feature or request released

Comments

@lamyergeier
Copy link

Recently Youtube has shifted the "Open Transcript" button from the "3 dots menu" below the player to in the bottom of description. Now we have to scroll and search for this "Open Transcript" button.

Could you please add "Open Transcript" button in the Feature Menu in the player?
@VampireChicken12
Copy link
Member

@lamyergeier Let me look into it and I'll get back to you.

@VampireChicken12 VampireChicken12 self-assigned this Dec 10, 2023
@VampireChicken12 VampireChicken12 added the enhancement New feature or request label Dec 10, 2023
@VampireChicken12 VampireChicken12 moved this to In Progress in YouTube Enhancer Dec 10, 2023
@VampireChicken12
Copy link
Member

@lamyergeier The feature is done being coded it will be available in the next release. I still have a couple things to finish up before then.

@VampireChicken12 VampireChicken12 moved this from In Progress to Done in YouTube Enhancer Dec 11, 2023
github-actions bot pushed a commit that referenced this issue Dec 15, 2023
@semantic-release-bot
chore(release): 1.17.0 [skip ci]
0e7b712 
# [1.17.0](v1.16.3...v1.17.0) (2023-12-15)

### Bug Fixes

* **feature menu:** ads button now dimmed when feature menu is open ([2dea512](2dea512)), closes [#162](#162)

### Features

* add open transcript button to feature menu ([36d91d7](36d91d7)), closes [#164](#164)

## Release Artifacts
| File Name | SHA-256 Hash |
| :--- | :---: |
| youtube-enhancer-v1.17.0-Chrome.zip | 53f2675ff8b2c8d5324b76314d4c209757874460448b4c847d4329a99adc9c13 |
| youtube-enhancer-v1.17.0-Chromium.zip | 53f2675ff8b2c8d5324b76314d4c209757874460448b4c847d4329a99adc9c13 |
| youtube-enhancer-v1.17.0-Edge.zip | 53f2675ff8b2c8d5324b76314d4c209757874460448b4c847d4329a99adc9c13 |
| youtube-enhancer-v1.17.0-Firefox.zip | cd48448b32f9be65e194f7843872ced9b92eeae4992ca446ef38d9d03c941960 |
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 1.17.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@VampireChicken12
Copy link
Member

@lamyergeier the feature is available now

@VampireChicken12
Copy link
Member

@all-contributors please add @lamyergeier for ideas

@allcontributors allcontributors bot mentioned this issue Dec 18, 2023
Merged
@allcontributors AllContributors
Copy link
Contributor

@VampireChicken12

I've put up a pull request to add @lamyergeier! 🎉

@lamyergeier
Copy link
Author

@VampireChicken12 I am using v1.17.1. But I don't see the show transcript, as can be seen below:

image

@VampireChicken12
Copy link
Member

@lamyergeier is the option enabled in the settings and does that video actually have a transcript? The button only appears when the video has a transcript

@VampireChicken12
Copy link
Member

I just tested with the same video, it does have one but the button didn't appear let me look into the code and figure out what is going wrong that the button isn't appearing

VampireChicken12 added a commit that referenced this issue Dec 18, 2023
@VampireChicken12
fix(open transcript button): fix open transcript button not appearing
3b4392c 
wait for transcript button to appear
#164
github-actions bot pushed a commit that referenced this issue Dec 18, 2023
@semantic-release-bot
chore(release): 1.17.2 [skip ci]
4115086 
## [1.17.2](v1.17.1...v1.17.2) (2023-12-18)

### Bug Fixes

* **open transcript button:** fix open transcript button not appearing ([3b4392c](3b4392c)), closes [#164](#164)

## Release Artifacts
| File Name | SHA-256 Hash |
| :--- | :---: |
| youtube-enhancer-v1.17.2-Chrome.zip | 58082e354dc145f0d93866b7855684affbfc94d240bacc916d99398e125c288c |
| youtube-enhancer-v1.17.2-Chromium.zip | 58082e354dc145f0d93866b7855684affbfc94d240bacc916d99398e125c288c |
| youtube-enhancer-v1.17.2-Edge.zip | 58082e354dc145f0d93866b7855684affbfc94d240bacc916d99398e125c288c |
| youtube-enhancer-v1.17.2-Firefox.zip | 4bd7098d1f06de580462b381b66df1b46d0d99f943ae3cc72172af87f81953c0 |
@VampireChicken12
Copy link
Member

@lamyergeier version 1.17.2 is live on Mozilla Addons the feature is fixed in that version. Make sure to check for updates then try again.

@livingflore livingflore moved this to Done in YouTube Enhancer Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VampireChicken12 VampireChicken12

Labels
enhancement New feature or request released
Projects
YouTube Enhancer
Status: Done - Released
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lamyergeier @VampireChicken12