You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since github provides a nice and clean way to get the latest version from api, maybe add a version check on update? Simply printing something along the lines of an orang text line under the puddler ascii reading something like. Version (Running Version), latest release (Latest upstream release)
Bonus points for eventually adding U as a command that shows up in the list to update from github directly, but I am not sure that's something you can easily do, just letting users know there's a new version and making the U prompt take them to the latest release is probably good enough.
The text was updated successfully, but these errors were encountered:
calmcacil
changed the title
Self update check on start?
Version check on start and potential self-upgrade?
Oct 4, 2023
I can tell, how useful this feature could be, but there are a few things about would come from it that I really hate.
Hardcoding
I really hate to burn dependencies (f.e. repository url) like this into the code. It makes forking it a lot harder, since all of these things would have to be changed to make the code fully functional in a different repository.
Privacy / Complexity
Then there is the thing about privacy. Sure, auto-checking would be an optional setting, but firstly, we already got a few of those, and secondly, it would add another, not so insignificant, layer to the program. Also bugging github every time someone starts the script doesn't seem very effective for me. (so save the time of the latest check in the configuration?!)
I will keep this issue open, until I've made a decision.
Handling the concern of hard coding repo urls and privacy under the same idea here. How about enabling auto updates by defining the repo url in the config? combined with using timestamps as a config value for when the last check was and only checking it if its been a while since it last checked? Not that im concerned that hitting github on startup would cause enough concern to actually worry about since plenty of people use scripts for updating that hit those api's to begin with.
Since github provides a nice and clean way to get the latest version from api, maybe add a version check on update? Simply printing something along the lines of an orang text line under the puddler ascii reading something like.
Version (Running Version), latest release (Latest upstream release)
Bonus points for eventually adding U as a command that shows up in the list to update from github directly, but I am not sure that's something you can easily do, just letting users know there's a new version and making the U prompt take them to the latest release is probably good enough.
The text was updated successfully, but these errors were encountered: