Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add discarded_futures #74

Closed
ricardodalarme opened this issue May 8, 2023 · 2 comments
Closed

[Feature Request] Add discarded_futures #74

ricardodalarme opened this issue May 8, 2023 · 2 comments

Comments

@ricardodalarme
Copy link

Description

Making asynchronous calls in non-async functions usually signals a programming error. These functions should generally be marked async, and such futures should probably be awaited (as enforced by unawaited_futures).

So, to avoid this kind of problem, it would be really nice to have the discarded_futures included in the analysis.

Documentation

@renancaraujo
Copy link
Contributor

After some reasearch, seems like there are some unresolved false positives issues with this rule.

dart-lang/sdk#58911

dart-lang/sdk#59044

dart-lang/sdk#59151

Dealing with false positives is the biggest blocker for this issue to be added to VG analysis IMO

@tomarra
Copy link
Contributor

tomarra commented Jul 16, 2024

With this issue being open for over a year and no new comments, along with Dart issues still being open on it, closing this out as a won't fix. If this should be re-addressed in the future feel free to open another issue with updated information.

@tomarra tomarra closed this as not planned Won't fix, can't repro, duplicate, stale Jul 16, 2024
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in VGV Open Source 🦄 🧙🌟 Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants