-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New video player #2387
Comments
If possible, mobile gestures for brightness and volume, like Android VLC or NewPipe, would be nice. When in fullscreen mode, they allow adjusting brightness by moving with one finger up and down on the left half of the screen, and volume doing the same on the right half. Looking forward to the new player, looks very promising! |
Volume would be possible, but websites cannot adjust screen brightness unfortunately Edit: added to the todo list |
Just tried the code and have to say the new video player looks really good and and works way better for me (the quality selection is actually enforced). |
I have some ideas for the UX. I know it is a work in progress, but I wanted to share my thoughts. For the speed settings currently there is a checkbox to change the input type in the same line with the actual speed setting. I think this could be split into two different settings/lines and the Show video speed as a list setting could be moved entirely to the global settings menu, so that the "local" playback settings are relevant for the current video only. These things don't necessarily need to be implemented and also don't need to be implemented within this one pull request. These small details can be checked again and maybe implemented after the video player is finished. Since this is a WIP you might have planned this anyway, just wanted to give my two cents. If you need help with some part or just want to offload something to someone else, I'd be happy to help! Edit: fixed typos |
Is it the duration bug? |
Playback in general is not working. I haven't heard of that bug tho. |
I really love the new player, and the fact that it will enforce the quality setting, however the default "Auto" quality setting is somewhat annoying. I'd love to see a default quality setting sometime, if you're up for it! Love the project, and thank you for keeping it maintained! |
Features
The text was updated successfully, but these errors were encountered: