Replace Thread.stop with cancellation #438
Labels
Priority: Medium
Medium priority
Subsystem: IO
Anything concerning the File I/O system
Type: Enhancement
New feature or request
Is your feature request related to a problem? Please describe.
ClassWrapper
usesThread.stop
to implement method decompilation time limits, which is deprecated for removal. It also creates a new thread per method.Describe the solution you'd like
Since we now have
CancelationManager
, and itscheckCanceled
method is called regularly, we could modifyCancelationManager
to support the concept of a time limit and remove the threading entirely.Additional context
Take note of
CancelationManager.cancelationChecker
when modifyingCancelationManager
,setCancelationChecker
is (or at least will be) called by the intellij plugin for its own cancelation requests. When canceled by vineflower-intellij, the entire decompilation process should be canceled and not just a single method, so it might be worth storing the type of the cancelation inCancelationException
.The text was updated successfully, but these errors were encountered: