Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Thread.stop with cancellation #438

Open
Earthcomputer opened this issue Nov 2, 2024 · 0 comments
Open

Replace Thread.stop with cancellation #438

Earthcomputer opened this issue Nov 2, 2024 · 0 comments
Labels
Priority: Medium Medium priority Subsystem: IO Anything concerning the File I/O system Type: Enhancement New feature or request

Comments

@Earthcomputer
Copy link
Contributor

Is your feature request related to a problem? Please describe.

ClassWrapper uses Thread.stop to implement method decompilation time limits, which is deprecated for removal. It also creates a new thread per method.

Describe the solution you'd like

Since we now have CancelationManager, and its checkCanceled method is called regularly, we could modify CancelationManager to support the concept of a time limit and remove the threading entirely.

Additional context

Take note of CancelationManager.cancelationChecker when modifying CancelationManager, setCancelationChecker is (or at least will be) called by the intellij plugin for its own cancelation requests. When canceled by vineflower-intellij, the entire decompilation process should be canceled and not just a single method, so it might be worth storing the type of the cancelation in CancelationException.

@jaskarth jaskarth added Type: Enhancement New feature or request Subsystem: IO Anything concerning the File I/O system Priority: Medium Medium priority labels Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Medium Medium priority Subsystem: IO Anything concerning the File I/O system Type: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants