Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

f-string syntax errors #57

Open
3 tasks done
bebertii opened this issue Sep 26, 2024 · 4 comments
Open
3 tasks done

f-string syntax errors #57

bebertii opened this issue Sep 26, 2024 · 4 comments

Comments

@bebertii
Copy link

Steps to reproduce

when I clone the repo and then try to launch main.py

Expected behavior

It shoud work

Actual behavior

multiple f-strings errors

Errors

No response

EmuHaven version

0.14.0 from git

Operating System

windows

Other details

every f-string is fucked up with incorrect quotation marks, for example in thread_event_manager.py on line 55
self.logger.warning(f"Event {event["id"]} returned no result")
it should be self.logger.warning(f"Event {event['id']} returned no result")

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
  • I have written a short but informative title.
  • I have updated the app to version 0.14.0.
@Viren070
Copy link
Owner

What python version are you using?

@bebertii
Copy link
Author

I'm using python 3.10

@Viren070
Copy link
Owner

This project requires 3.12

@Viren070
Copy link
Owner

Sorry for the brief responses.

I have a bit more time now, so here's a more proper response.

I prefer using the double quotations, and when I heard that 3.12 supported using double quotations within double quoations, I thought, why not.

Although I could change all the f strings to conform to <3.12 syntax, I don't know when I will be able to do that. So, for now, you'll have to use Python 3.12 or greater. I apologise for any inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants