-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RangeOfT enhancements for simplicity to consumers #90
Comments
I put an upvote on this discussion, I probably should have made a comment also. If you would like to create a separate branch from master and make this change, we will be able to pull the Vts.Gui.Wpf into the solution to make sure the binding still works as expected. |
Cool, thanks Lisa! I'm on it. :) |
Thank you!! |
There are multiple failing unit tests in the VTS, MCCL and PP (192), is it possible that this has affected the serialization/deserialization. When we make changes like this to the library we have to run unit tests before we create the PR. I think this code change needs investigating more. |
Ok, I'll take a look. Pretty sure this is a JSON.Net issue that I've fixed before. Sorry - was trying to get something out to you quickly yesterday. |
Pushed the small fix (this one gets me every time). Sorry for the churn - I'm used to pushing my changes to my remote branch and getting build/test automatically done for me, which blocks PR creation in the first place. |
(all tests passing now) |
Thanks! Let me review it on the branch first before recreating the PR. |
This was discussed in #81 and is rearing it's head as I try to make the Notbooks simple and refactor commonly used code/extensions to the Vts core.
Originally posted by dcuccia August 11, 2023
I've found, in creating the user samples, the utility of having extension method operators on
Range<T>
objects. The need to callmyRange.AsEnumerable().ToArray()
is unconcise and not very intuitive to newcomers. It will also be that much more confusing if we need to add any additional calls to make it compatible with PythonNet.In order to resolve these, I'd propose:
ToArray()
extension method in a newRangeExtensions
classThis would also clean up the code significantly throughout the codebase. Only check would be to ensure that any WPF databinding to a Range isn't disrupted by it newly implenting
IEnumerable<T>
(sometimes there are weird defaults, but this one is easy to check that databinding continues to work).The text was updated successfully, but these errors were encountered: