Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve input validation and error handling when parsing .md files #1289

Closed
Gedochao opened this issue Aug 25, 2022 · 0 comments · Fixed by #1550
Closed

Improve input validation and error handling when parsing .md files #1289

Gedochao opened this issue Aug 25, 2022 · 0 comments · Fixed by #1550
Assignees
@Gedochao
Labels
bug Something isn't working markdown

Comments

@Gedochao
Copy link
Contributor

Gedochao commented Aug 25, 2022 •
edited
Loading

Version(s)
nightly

Describe the bug
The input validation for Markdown files is a bit naive right now.
Only the contents of scala code blocks are validated, while the Markdown code as a whole is not.

To Reproduce

# Unclosed snippet
```scala

Expected behaviour
Markdown files should be validated as a whole when they are compiled, and not just their scala code blocks' contents
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gedochao Gedochao

Labels
bug Something isn't working markdown
Projects
Scala CLI Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add error handling for unclosed code blocks in Markdown inputs Gedochao/scala-cli
1 participant
@Gedochao