Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid multiple hardcoding of default JDK #3084

Closed
yadavan88 opened this issue Aug 8, 2024 · 0 comments · Fixed by #3087
Closed

Avoid multiple hardcoding of default JDK #3084

yadavan88 opened this issue Aug 8, 2024 · 0 comments · Fixed by #3087
Assignees
@Gedochao
Labels
internal Internal or build-related changes jvm Issues tied to the JVM platform

Comments

@yadavan88
Copy link
Contributor

Currently, the default jdk version(17) is hardcoded and used independently in multiple places. Instead, it should be moved to a constant and used across for easy maintainability.
@yadavan88 yadavan88 added the bug Something isn't working label Aug 8, 2024
@Gedochao Gedochao added internal Internal or build-related changes jvm Issues tied to the JVM platform and removed bug Something isn't working labels Aug 9, 2024
@Gedochao Gedochao mentioned this issue Aug 9, 2024
Merged
@Gedochao Gedochao self-assigned this Aug 9, 2024
@Gedochao Gedochao moved this from To do to In progress in Scala CLI Board Aug 9, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Scala CLI Board Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gedochao Gedochao

Labels
internal Internal or build-related changes jvm Issues tied to the JVM platform
Projects
Scala CLI Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Extract used Java versions to constants Gedochao/scala-cli
2 participants
@yadavan88 @Gedochao