Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-left-to-right parsing of dice roll notation #85

Open
Vlek opened this issue May 7, 2022 · 1 comment
Open

Non-left-to-right parsing of dice roll notation #85

Vlek opened this issue May 7, 2022 · 1 comment
Assignees
@Vlek
Labels
bug Something isn't working
Milestone
3.0

Comments

@Vlek
Copy link
Owner

Vlek commented May 7, 2022

Things like 4d6K1d2 are not happening from left-to-right. Right now, this is the order that they're being handled:

❯ roll 4d6K1d2 -v
Rolled: 4d6: [6, 2, 5, 6]
Rolled: 1d2: [1]
Adding: 19 + 1 = 20
Keeping highest: 1: [6]
6

The expected order would be:
Roll 4d6
Keep the highest 1
Roll the highest 1d6 roll's worth of d2
@Vlek Vlek self-assigned this May 10, 2022
@Vlek Vlek added the bug Something isn't working label May 10, 2022
@Vlek Vlek added this to the 3.0 milestone May 10, 2022
@Vlek
Copy link
Owner Author

Vlek commented May 10, 2022

If I do this right, this should also resolve #45.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Vlek Vlek

Labels
bug Something isn't working
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
1 participant
@Vlek