Pyparsing #21
Merged
Pyparsing #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
October 25, 2020 14:50
including fixing the dependencies via poetry.
roll module should be usable completely outside of the idea of a click CLI script. This allows that to happen! Starting to work on figuring out PyParse. In order to do this, I started creating railroad diagrams for the parsing. This should hopefully make my time going forward much easier.
Things are going well toward redoing the parser and moving from parsley to pyparser. However, there are some edge cases currently that are not going well, namely going back and forth between the different order of operations. There are also some errors that we're not throwing like we used to. Things like "9." are getting parsed by the new parser. Either we have to change our expectations or change how the code interprets numbers, both int and floats.
Fixed the issue with order of operations so that all of the math works as expected. Now there are only a handful of issues left to address with the most pressing being the issue with dice in the notation: "d20" without an explicit number of dice.
There are only two that aren't passing: The verbose output check and an error that should be raised parsing "9.". There are other things that are broken as well that we do not have tests for currently, such as ".0" as well as "--3" with a unary operator on a negative number.
Using the packrat option has greatly increased the speed of the code. However, in researching, I have found that I have a recursive grammar issue with the dice notation that needs to be addressed to increase the speed further.
This concludes all of the necessary work to move back to the master branch as we now perform all base functionality with the new parser.
This was
linked to
issues
Feb 4, 2021
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This concludes the necessary work to merge back to master. All of the old parser functionality is also included in the new one.