Ensured 100% test coverage. #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While working on coverage, some issues were resolved: 1) Because of how the DiceParser object was being instantiated and used across multiple tests, the RollOption.Maximize was being used in more cases than it was supposed to. Once this was resolved, other tests showed that they did not have correct ranges. The output was reviewed and either the test was updated or the code was to accomodate expected results. 2) Some operations were not being used and it became apparent by the coverage report. This was also the case for types that did not need to have their logic present in things like __rmod__ where the __mod__ method would handle the case instead. 3) There are a few methods for objects that we will want to keep because they will be needed later on that are not current used. To make sure that our coverage is complete, I had to test these internal files instead of end-to-end testing. After we add the new features, we should re-evaluate these additions to consider whether they're actually needed. To do this, we should run pytest specifically against test_roll_dice.py or other scripts that do end-to-end testing only.
Had to increment the python version due to the type notations that we are using. The annotations are not available in 3.6 unfortunately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on coverage, some issues were resolved:
across multiple tests, the RollOption.Maximize was being used in more
cases than it was supposed to. Once this was resolved, other tests
showed that they did not have correct ranges. The output was reviewed
and either the test was updated or the code was to accomodate
expected results.
coverage report. This was also the case for types that did not need
to have their logic present in things like rmod where the mod
method would handle the case instead.
they will be needed later on that are not current used. To make sure
that our coverage is complete, I had to test these internal files
instead of end-to-end testing. After we add the new features, we
should re-evaluate these additions to consider whether they're
actually needed. To do this, we should run pytest specifically
against test_roll_dice.py or other scripts that do end-to-end
testing only.