Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vwc-side-drawer): add modal support #1002

Merged
merged 93 commits into from
Aug 16, 2021
Merged

Conversation

rinaok
Copy link
Contributor

@rinaok rinaok commented Aug 3, 2021

Description

Motivation and Context

All Submissions:

  • I followed the guidelines in our Contributing document?
  • My code follows the code style of this project
  • I checked to ensure there aren't other open Pull Requests for the same update/change?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

Checklist:

  • API Changes are documented in code and exported accordingly (JSDoc)

@yinonov
Copy link
Contributor

yinonov commented Aug 10, 2021

  • Add a11y tests
  • Test focus trapping
  • Escape closes modal
  • Focus trap removed

Copy link
Contributor

@yinonov yinonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://jsdoc.app/tags-fires.html will help producing docs on our opened/closed events

@yinonov yinonov changed the title Vwc side drawer modal feat(vwc-side-drawer): add modal support Aug 15, 2021
@rinaok rinaok marked this pull request as ready for review August 15, 2021 15:27
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@yinonov yinonov merged commit 02e2782 into master Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants