Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vwc-side-drawer): remove absolute support #1029

Merged
merged 54 commits into from
Aug 25, 2021
Merged

Conversation

rinaok
Copy link
Contributor

@rinaok rinaok commented Aug 23, 2021

Description

Motivation and Context

All Submissions:

  • I followed the guidelines in our Contributing document?
  • My code follows the code style of this project
  • I checked to ensure there aren't other open Pull Requests for the same update/change?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

Checklist:

  • API Changes are documented in code and exported accordingly (JSDoc)

@changeset-bot
Copy link

changeset-bot bot commented Aug 23, 2021

⚠️ No Changeset found

Latest commit: e50e634

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link

🚀

Latest successful build of the PR deployed here.

🚀

@rinaok rinaok changed the title vwc-side-drawer-absolute feat(vwc-side-drawer): remove absolute support Aug 23, 2021
ui-tests/tests/vwc-side-drawer/index.js Outdated Show resolved Hide resolved
yarn.lock Outdated Show resolved Hide resolved
@rinaok rinaok requested a review from yinonov August 24, 2021 08:32
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rinaok rinaok merged commit b00ded7 into master Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants