Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vwc-inline): add more inline size options #1053

Merged
merged 140 commits into from
Oct 6, 2021
Merged

feat(vwc-inline): add more inline size options #1053

merged 140 commits into from
Oct 6, 2021

Conversation

rinaok
Copy link
Contributor

@rinaok rinaok commented Sep 5, 2021

Description

Motivation and Context

All Submissions:

  • I followed the guidelines in our Contributing document?
  • My code follows the code style of this project
  • I checked to ensure there aren't other open Pull Requests for the same update/change?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

Checklist:

  • API Changes are documented in code and exported accordingly (JSDoc)

@rinaok rinaok requested a review from yinonov September 29, 2021 09:45
@rinaok
Copy link
Contributor Author

rinaok commented Sep 30, 2021

@yinonov Should we change the name to vwc-layout now? Or later?

@yinonov
Copy link
Contributor

yinonov commented Oct 3, 2021

@yinonov Should we change the name to vwc-layout now? Or later?

add another PR, just to have clear comparison for review

components/inline/readme.md Outdated Show resolved Hide resolved
components/inline/src/vwc-inline.scss Outdated Show resolved Hide resolved
components/inline/src/vwc-inline.scss Outdated Show resolved Hide resolved
components/inline/src/vwc-inline.scss Outdated Show resolved Hide resolved
components/inline/test/inline.test.js Outdated Show resolved Hide resolved
@rinaok rinaok requested a review from yinonov October 5, 2021 08:22
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 5, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@yinonov yinonov merged commit 1b8020d into master Oct 6, 2021
@yinonov yinonov deleted the vwc-grid branch October 6, 2021 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants