Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vwc-top-app-bar): alternate #1087

Merged
merged 20 commits into from
Oct 12, 2021
Merged

fix(vwc-top-app-bar): alternate #1087

merged 20 commits into from
Oct 12, 2021

Conversation

rinaok
Copy link
Contributor

@rinaok rinaok commented Oct 10, 2021

Description

Motivation and Context

All Submissions:

  • I followed the guidelines in our Contributing document?
  • My code follows the code style of this project
  • I checked to ensure there aren't other open Pull Requests for the same update/change?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

Checklist:

  • API Changes are documented in code and exported accordingly (JSDoc)

@github-actions
Copy link

🚀

Latest successful build of the PR deployed here.

🚀

@rinaok rinaok changed the title fix(vwc-top-aoo-bar): alternate fix(vwc-top-app-bar): alternate Oct 10, 2021
yinonov
yinonov suggested changes Oct 12, 2021
View reviewed changes
components/top-app-bar-fixed/stories/arg-types.js Outdated Show resolved Hide resolved
components/top-app-bar/stories/arg-types.js Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@yinonov yinonov merged commit 9ecf5ed into master Oct 12, 2021
@yinonov yinonov deleted the viv-740-top-app-bar-alternate branch October 12, 2021 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yinonov yinonov yinonov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rinaok @yinonov