fix(vwc-button): multiple click events generated on button #1101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
August 16, 2021 17:18
|
🚀 Latest successful build of the PR deployed here. 🚀 |
|
The way to solve this would be to create a test that shows the error (e.g. shows we get more than one click) and then create a solution that makes this test pass. |
YonatanKra
force-pushed
the
VIV-754-multiple-click-events-on-button
branch
from
fedea26 to
9fc2a8e
Compare
YonatanKra
force-pushed
the
VIV-754-multiple-click-events-on-button
branch
from
402b525 to
0334990
Compare
yinonov
approved these changes
Oct 20, 2021
yinonov
approved these changes
Oct 20, 2021
yinonov
approved these changes
Oct 20, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected behavior
When clicking a "submit" vwc-button, it should generate exactly one "click" event
Current behavior
When clicking a "submit" vwc-button, at-least two events are being fired:
Click (button) -> Submit (form) -> Click (button)
VIV-752