fix(elevation): sharp or rounded shape #1185
Conversation
rachelbt
commented
Jan 2, 2022
•
rachelbt
commented
- Test are still needed
- wondering regard removing border radius & background-color variables - may deprecated - thought it is still in Alfa
|
🚀 Latest successful build of the PR deployed here. 🚀 |
rachelbt
added
the
Work in Progress
| @@ -1,8 +1,6 @@ | |||
| @use 'sass:list'; | |||
|
|
|||
| $dps: 0 2 4 8 12 16 24; | |||
| $vvd-elevation-background-color: --vvd-elevation-background-color; | |||
There was a problem hiding this comment.
These constants prevent typos that may occur by authoring "magic strings".
Even if used in a single page, renaming a variable may leave a reference outdated. While constants will break the compilation early
There was a problem hiding this comment.
I removed that line anyway :)
There was a problem hiding this comment.
right, don't. it helps ensure we use the right css variable. rule of thumb
| @@ -1,8 +1,6 @@ | |||
| @use 'sass:list'; | |||
|
|
|||
| $dps: 0 2 4 8 12 16 24; | |||
There was a problem hiding this comment.
Shouldn't this be coming from tokens automatically?
There was a problem hiding this comment.
not sure what you mean. This is for the sass loop :)
There was a problem hiding this comment.
probably not related to this PR, but the values are hardcoded here instead of being imported from style tokens
There was a problem hiding this comment.
That what was there - I merely added the 0 ;)
� Conflicts: � components/elevation/src/vwc-elevation.scss
|
@rachelbt merge? |
|
Kudos, SonarCloud Quality Gate passed!
|
