fix(card): integrate elevation #1273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Latest successful build of the PR deployed here. 🚀 |
yinonov
suggested changes
Apr 5, 2022
|
|
||
| declare global { | ||
| interface HTMLElementTagNameMap { | ||
| 'vwc-card': VWCCard; | ||
| } | ||
| } | ||
|
|
||
| const elevationSets = ['0' , '2', '4', '8', '12' , '16' , '24']; |
There was a problem hiding this comment.
can be imported from elevation
There was a problem hiding this comment.
there are none in the elevation comp... 😨
There was a problem hiding this comment.
nop... the design tokens are like this: --vvd-shadow-surface-4dp
There was a problem hiding this comment.
we should open a ticket to support ts types of elevation tokens
yinonov
suggested changes
Apr 15, 2022
yinonov
approved these changes
Apr 24, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
k-paxian
pushed a commit
that referenced
this pull request
Apr 25, 2022
* fix(card): integrate elevation * typo fix * update test md * style for elevation part * clean code * card block-size * add elevation story + meta * content slot story * change dp to elevation * containment * updates * update snapshot * Fix Safari test * remove only :) * typo * typo Co-authored-by: yinonov <[email protected]> Co-authored-by: yonatankra <[email protected]>
yinonov
added a commit
that referenced
this pull request
May 3, 2022
* introduce support for `filterable` columns * Update spring-hack-challenge.md * fix(card): integrate elevation (#1273) * fix(card): integrate elevation * typo fix * update test md * style for elevation part * clean code * card block-size * add elevation story + meta * content slot story * change dp to elevation * containment * updates * update snapshot * Fix Safari test * remove only :) * typo * typo Co-authored-by: yinonov <[email protected]> Co-authored-by: yonatankra <[email protected]> * Update spring-hack-challenge.md * Update vwc-data-grid-column.ts * Update vwc-data-grid-column.ts Co-authored-by: Yonatan Kra <[email protected]> Co-authored-by: rachelbt <[email protected]> Co-authored-by: yinonov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated the style as in vivid-3:
Vonage/vivid-3#268
added hight property to match the elevation inside card