Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(audio): auto disable audio when invalid src (VIV-877) #1394

Merged
merged 17 commits into from
Apr 19, 2023

Conversation

YonatanKra
Copy link
Contributor

No description provided.

@github-actions
Copy link

🚀

Latest successful build of the PR deployed here.

🚀

olaf-k
olaf-k previously requested changes Apr 17, 2023
components/audio/src/vwc-audio.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@rachelbt rachelbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

audio disabled state UI is broken

@YonatanKra YonatanKra force-pushed the VIV-877-auto-disable-audio-when-invalid-src branch from 6d55ca9 to 35f6442 Compare April 18, 2023 10:34
@YonatanKra YonatanKra dismissed stale reviews from rachelbt and olaf-k April 18, 2023 13:58

Fixed

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@rachelbt rachelbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in storybook all examples are disabled...

Copy link
Contributor

@rachelbt rachelbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants