-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: iss 520/viv 212 headers elements #524
Conversation
…/viv-212-headers-elements
…/viv-212-headers-elements
🚀 Latest successful build of the PR deployed here. 🚀 |
Minimum allowed coverage is Generated by 🐒 cobertura-action against 13511b0 |
@include typography.typography-cat-shorthand('body-1-code'); | ||
code, | ||
kbd { | ||
font-family: 'SpeziaMonoWebVariable', monospace; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel we should limit the use to a specific category
@include typography.typography-cat-shorthand('body-1-code'); | ||
code, | ||
kbd { | ||
font-family: 'SpeziaMonoWebVariable', monospace; | ||
} | ||
|
||
b, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this can be an issue, wrapping tags in other categories will result in breaking category typography
@@ -48,7 +52,6 @@ | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this can be an issue, wrapping tags in other categories will result in breaking category typography
@@ -48,7 +52,6 @@ | |||
} | |||
|
|||
samp, | |||
kbd, | |||
var { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's talk about all
<code> | Defines a piece of computer code
<samp> | Defines sample output from a computer program
<kbd> | Defines keyboard input
<pre> | Defines preformatted text
/// UTIL FNS | ||
function assert(condition: any, msg?: string): asserts condition { | ||
// UTIL FNS | ||
function assert(condition: boolean, msg?: string): asserts condition { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not correct, please remove this modification as it's handled in #528
this handled in the other PR
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
closes #520