Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: iss 520/viv 212 headers elements #524

Merged
merged 14 commits into from
Dec 29, 2020

Conversation

gullerya
Copy link
Contributor

closes #520

Verified

This commit was signed with the committer’s verified signature.
Hzfengsy Siyuan Feng

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
…/viv-212-headers-elements

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
…/viv-212-headers-elements
@github-actions
Copy link

🚀

Latest successful build of the PR deployed here.

🚀

@github-actions
Copy link

github-actions bot commented Dec 27, 2020

File Coverage
All files 80%
common/context/src/vvd-context.ts 97%
common/fonts/src/vvd-fonts.ts 83%
common/foundation/src/form-association/associate-with-form.ts 89%
common/foundation/src/form-association/common.ts 90%
common/foundation/src/form-association/submit-on-enter-key.ts 80%
common/scheme/src/os-sync.utils.ts 58%
common/scheme/src/vvd-scheme-style-tag-handler.ts 79%
common/scheme/src/vvd-scheme.ts 82%
components/audio/src/vwc-audio.ts 60%
components/button/src/vwc-button.ts 78%
components/carousel/src/vwc-carousel.ts 71%
components/drawer/src/vwc-drawer.ts 42%
components/fab/src/vwc-fab.ts 63%
components/file-picker/src/vwc-file-picker.ts 67%
components/icon-button-toggle/src/vwc-icon-button-toggle.ts 67%
components/icon-button/src/vwc-icon-button.ts 67%
components/icon/src/vwc-icon.js 92%
components/list/src/vwc-list-expansion-panel.ts 73%
components/list/src/vwc-list-item.ts 80%
components/media-controller/src/vwc-media-controller.ts 84%
components/select/src/vwc-select.ts 90%
components/slider/src/vwc-slider.ts 88%
components/textarea/src/vwc-textarea.ts 81%
components/textfield/src/vwc-textfield.ts 90%
components/theme-switch/src/vwc-theme-switch.ts 88%

Minimum allowed coverage is 75%

Generated by 🐒 cobertura-action against 13511b0

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@gullerya gullerya requested a review from yinonov December 27, 2020 20:08
@include typography.typography-cat-shorthand('body-1-code');
code,
kbd {
font-family: 'SpeziaMonoWebVariable', monospace;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel we should limit the use to a specific category

@include typography.typography-cat-shorthand('body-1-code');
code,
kbd {
font-family: 'SpeziaMonoWebVariable', monospace;
}

b,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be an issue, wrapping tags in other categories will result in breaking category typography

@@ -48,7 +52,6 @@
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be an issue, wrapping tags in other categories will result in breaking category typography

@@ -48,7 +52,6 @@
}

samp,
kbd,
var {
Copy link
Contributor

@yinonov yinonov Dec 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's talk about all

<code> | Defines a piece of computer code
<samp> | Defines sample output from a computer program
<kbd> | Defines keyboard input
<pre> | Defines preformatted text

components/list/src/vwc-list-expansion-panel.ts Outdated Show resolved Hide resolved
components/list/src/vwc-list-expansion-panel.ts Outdated Show resolved Hide resolved
@gullerya gullerya requested a review from yinonov December 29, 2020 15:04
/// UTIL FNS
function assert(condition: any, msg?: string): asserts condition {
// UTIL FNS
function assert(condition: boolean, msg?: string): asserts condition {
Copy link
Contributor

@yinonov yinonov Dec 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not correct, please remove this modification as it's handled in #528

this handled in the other PR
@gullerya gullerya requested a review from yinonov December 29, 2020 17:10
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@gullerya gullerya merged commit 20eaa8c into master Dec 29, 2020
@gullerya gullerya deleted the iss-520/viv-212-headers-elements branch December 29, 2020 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VIV-212 finalize-adjust headers styles
2 participants