Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vwc-list): list items twoline breaks on safari #684

Merged
merged 2 commits into from
Feb 28, 2021
Merged

fix(vwc-list): list items twoline breaks on safari #684

merged 2 commits into from
Feb 28, 2021

Conversation

yinonov
Copy link
Contributor

@yinonov yinonov commented Feb 27, 2021

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@yinonov
fix(vwc-list): list items twoline breaks on safari
4efe112 
css logical properties (margin) break on safari
@github-actions
Copy link

🚀

Latest successful build of the PR deployed here.

🚀

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@gullerya gullerya merged commit 0d6becf into master Feb 28, 2021
@gullerya gullerya deleted the list-item-twoline-breaks-on-safari branch February 28, 2021 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gullerya gullerya gullerya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yinonov @gullerya