Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vwc-badge): element invisibility due to wrong z-indexing #717

Merged
merged 34 commits into from
Apr 4, 2021
Merged

fix(vwc-badge): element invisibility due to wrong z-indexing #717

merged 34 commits into from
Apr 4, 2021

Conversation

yinonov
Copy link
Contributor

@yinonov yinonov commented Mar 20, 2021

No description provided.

@github-actions
Copy link

🚀

Latest successful build of the PR deployed here.

🚀

yinonov and others added 26 commits March 20, 2021 09:43
@yinonov
tests pass viv-435
e477b7a
@yinonov
badge direct refs
53f4cef
@yinonov
connotation shade
c22cfdc
@yinonov
badge vary from layout mixin
6076623
@JoelGraham93
add scoped layout var to badge and icon-button
036d818
@JoelGraham93
Merge branch 'master' into viv-443-layout-mixin-scoped-vars
b549c21
@yinonov
safer scoped variables
cbde660
@yinonov
comment
dfb132c
@yinonov
added organized shades mixin
7e7e34f
@yinonov
connotation mixins refactored
684140b
@yinonov
connotations default mixin
cbe6838
@gullerya
Merge branch 'master' into VIV-435-background-color-invisible
b5e5cfc
@yinonov
linear progress updated to new connotation mixin
e3f9716
@yinonov
Merge branch 'VIV-435-background-color-invisible' of https://github.c…
84fd1cb 
…om/Vonage/vivid into VIV-435-background-color-invisible
@yinonov
icon button uses new connotation mixin
447ce7a
@yinonov
fix icon button
4fb1d9c
@yinonov
switch use of new connotation mixin
f5cb14a
@yinonov
note use of new connotation mixin
345ffdc
@yinonov
button use of new connotation mixin
2e39c3d
@yinonov
circular progress use new connotation mixin
3583ba4
@yinonov
remove shades
6f804a0
@yinonov
context theme use new connotation mixin
0da5ccc
@yinonov
remove refactored connotation mixin
8e6bb38
@yinonov
Merge branch 'master' into VIV-435-background-color-invisible
5d73486
@yinonov
remove announcement test from badge
9fe1e79
@yinonov
Merge branch 'master' into VIV-435-background-color-invisible
a7f6a74
@YonatanKra
Copy link
Contributor

I'm kinda ok with that. The only issue is - this PR reminds me why SCSS is so bad.
The amount of juggling I need to do in my brain just to remember where each variable is coming from...
Is there a way to simplify this?
I mean - what's the API? How do I use this?

@yinonov
Copy link
Contributor Author

yinonov commented Mar 30, 2021

I'm kinda ok with that. The only issue is - this PR reminds me why SCSS is so bad.
The amount of juggling I need to do in my brain just to remember where each variable is coming from...
Is there a way to simplify this?
I mean - what's the API? How do I use this?

I understand you, maybe that's where scss lacks types and all, what exactly is on your mind? maybe we can do it better

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 2, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@gullerya gullerya merged commit 2e9a91f into master Apr 4, 2021
@gullerya gullerya deleted the VIV-435-background-color-invisible branch April 4, 2021 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YonatanKra YonatanKra YonatanKra left review comments

@gullerya gullerya gullerya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yinonov @YonatanKra @gullerya @JoelGraham93