-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(datepicker): add week select support #806
Conversation
🚀 Latest successful build of the PR deployed here. 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jshenkman should week selection be set as range in input value? and if it's a week we select why the need for the actual date?
I'm not 100% sure about the use case so I'll check with Tisler today.. but in general, I think the week selection might be for the viewing part - so in the calendar, you will choose to view this week but the selection is still on the day - and that's the list of events you see (in VR, for example, they have under the date picker list of event and I'm not sure if those event are for the ay or week) |
Just noticed this as well - if you select the last week the hover cuts of and it looks funny.. we should complete that row with the dates of the next month like we do for the previous one. https://www.figma.com/file/r8OYLPmRmDqfLKt6KHdJDB/Vonage-UI-Kit-2.0?node-id=2897%3A421 |
Thanks @jshenkman, I've applied the design updates to PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hovering over a week and stepping out keeps the week highlighted, even if another is selected already
Screen.Recording.2021-05-12.at.13.47.12.mov
I'll look in to this. It's current behaviour in flatpickr but it's not nice |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Added flatpickr weekSelect plugin