fix(banner): height changes when dismissible

[tveinfeld]

https://jira.vonage.com/browse/VIV-559

[JoelGraham93]

May need some padding right when there is an action item but no dismiss button:

[github-actions]

🚀

Latest successful build of the PR deployed here.

🚀

[tveinfeld]

May need some padding right when there is an action item but no dismiss button:

done 👍

[JoelGraham93]

@jshenkman should we keep icon, button, dismiss in same position as volta when banner is multi-line?
Vivid:

Volta:

Also @tveinfeld the max height on the banner container might cut off content on smaller width devices - if not intended maybe the max height could be removed?

[jshenkman]

@jshenkman should we keep icon, button, dismiss in same position as volta when banner is multi-line?
Vivid:

Volta:

Also @tveinfeld the max height on the banner container might cut off content on smaller width devices - if not intended maybe the max height could be removed?

I actually think the Volta layout is a bit funny-looking... I would like to try having the icon top aligned and having the button and dismiss center aligned.
Here is an example -

We are making some design changes to the snack-bar (so we will have the legacy and new design) so I think this way the banner will be more consistent with the snack-bars layout

[JoelGraham93]

@jshenkman @yinonov @tveinfeld should we address the layout comments above in separate tasks to avoid scope creep of this PR?

[tveinfeld]

Good idea @JoelGraham93!

Let's try to review it only in the context of "height changes when dismissible" and put everything else onto Jira tickets to discuss and act upon later.

In that context - are we ready to approve and merge? @yinonov @JoelGraham93? 🙏

implemented

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication