Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use nodeJS http module instead of electron.net #19

Closed
lukechu10 opened this issue Sep 18, 2019 · 4 comments
Closed

Use nodeJS http module instead of electron.net #19

lukechu10 opened this issue Sep 18, 2019 · 4 comments
Labels
bug

Comments

@lukechu10
Copy link
Contributor

Currently, when running the example from Auth, the following error is throw: this.on is not a function. This seems to be an issue with got used with useElectronNet option.
@lukechu10
Copy link
Contributor Author

lukechu10 commented Sep 19, 2019 •
edited
Loading

The auth modules does not seem to work on electron in both the renderer process and the main process. It does however work in plain nodeJS.
Versions:
Electron: v6.0.9
NodeJS: v10.16.0
NpmJS: v6.11.3

Edit:
OS: Windows 10 build 1903

@ci010 ci010 added the bug label Sep 19, 2019
@ci010
Copy link
Collaborator

ci010 commented Sep 19, 2019

I'll keep this issue open but merge your PR first to unblock you.

As in my electron env, the auth module works. Maybe the latest version contains some bad thing... I'll check it later

@lukechu10
Copy link
Contributor Author

See issue: sindresorhus/got#443

@lukechu10
Copy link
Contributor Author

Since useElectronNet has been deprecated in got, I am going to close this issue for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ci010 @lukechu10