Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why only one icon type/size? (look at web app manifest) #2

Closed
kenchris opened this issue Jun 12, 2019 · 3 comments
Closed

Why only one icon type/size? (look at web app manifest) #2

kenchris opened this issue Jun 12, 2019 · 3 comments

Comments

@kenchris
Copy link

No description provided.

@rayankans
Copy link
Collaborator

@kenchris I'm not sure what the advantage of that would be. An icon URL would be enough, and follows suit of what the Notifications API does.

@quasicomputational
Copy link

Is this relying on Client-Hints to send the pixel density, and Accept to indicate which formats are acceptable, and then using server-driven content negotiation? I don't think that covers variant icon sizes (which header field would you set for that?): an icon with lots of pixels for display on a high-density display at a small size is likely different to an icon with lots of pixels for display on a low-density display at a large size.

Web Manifests has provision for the browser picking its preferred icon size, format, etc, which I think is a better design.

@rayankans
Copy link
Collaborator

I've given this some more thought, and I think it makes sense to pass a sequence of ImageResources for the reasons covered above and browser UI flexibility.

I've updated the explainer, but I'll keep this issue open in case more people have thoughts on the matter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants