You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Logging is still using string concatenation. Since this library is now fully using slf4j, it is time to remove string concatenation from logging.
Example
log.debug("some field is: " + field);
Can be
log.debug("some field is: {}");
This will result in some gain to speed of waffle as we will no longer instantiate strings to log when we may not be logging at that level.
At the same time, we should get rid of any other string concatenation. Use simple method that will append strings cleaner than using stringBuilders throughout possibly using Guava which is already part of the library.
The text was updated successfully, but these errors were encountered:
#101 is flagged with these changes. As soon as that is reviewed and accepted, will close this out. This was handled everywhere except where stringbuilders need used. Will work on that later as this was bigger than expected.
Logging is still using string concatenation. Since this library is now fully using slf4j, it is time to remove string concatenation from logging.
Example
log.debug("some field is: " + field);
Can be
log.debug("some field is: {}");
This will result in some gain to speed of waffle as we will no longer instantiate strings to log when we may not be logging at that level.
At the same time, we should get rid of any other string concatenation. Use simple method that will append strings cleaner than using stringBuilders throughout possibly using Guava which is already part of the library.
The text was updated successfully, but these errors were encountered: