Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correspondence option not available when not signed in (anonymous mode) #890

Open
Yurovoid opened this issue Feb 3, 2025 · 6 comments
Open
Labels
bug Something isn't working

Comments

@Yurovoid
Copy link

Yurovoid commented Feb 3, 2025

URL in which this issue happened: Lishogi.org

Steps to reproduce:

  1. Sign out if you're signed in
  2. Click on "Create a Game"/"Play with a friend"/"Play with the computer".
  3. Click on Time control drop down menu

I expected the drop down list to show two options:
Real time and correspondence

Instead, it showed me only one option: Real time

OS: Android 14
Browser & version: Chrome 132.0.6834.163

lv_0_20250130115651.mp4
@Yurovoid Yurovoid added the bug Something isn't working label Feb 3, 2025
@WandererXII
Copy link
Owner

That's the intended behaviour, if a player is signed out the game 'ownership' is being verified via cookie, but that's not very reliable for longer periods of time, more discussed here: #872

@Yurovoid
Copy link
Author

Yurovoid commented Feb 4, 2025

I see. What can an anonymous player possible do to play correspondence?
P.S. Can you check the no time limit issue, I have a suggestion

@WandererXII
Copy link
Owner

Well, the obvious thing to do is create an account. Unlimited is handled in the same way as correspondence so anons also won't be able to play that.

@Yurovoid
Copy link
Author

Yurovoid commented Feb 4, 2025

So while writing the code, did you intentionally want anons not be able to access the correspondence mode basically?

@WandererXII
Copy link
Owner

It's intentional, because without an account it's not possible to reliable make sure if this anon player is the one who should play the game.
Currently I think it's still possible for anon players to play correspondence -if registered user sends them a link to correspondence game, but this will be fixed in the next update.

@Yurovoid
Copy link
Author

Yurovoid commented Feb 5, 2025

Okay, I see. So basically the idea is anons cannot be trusted with correspondence? Maybe because they may take a lot of time? But that issue can happen in real time too, can't it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants