This repository has been archived by the owner on Nov 3, 2020. It is now read-only.
feat: new addFiles and addLinks methods #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkaitzgarro
force-pushed
the
refactor-internals
branch
from
9e4622c to
bb62a21
Compare
arkaitzgarro
force-pushed
the
refactor-internals
branch
from
80c6866 to
ff49e17
Compare
arkaitzgarro
changed the title
arkaitzgarro
force-pushed
the
refactor-internals
branch
from
ff49e17 to
65785ab
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Split and deprecate
addItemsmethod into two methods:addFilesandaddLinks. It's much more clear for developers to understand what are the doing.This PR also introduces models for Transfer, File and Link models, to be able to implement
EventEmitterpattern in the near future.Types of changes
Checklist