-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS AccentColor and AccentColorText system colors #136
Comments
Just realised this is implemented but returns a hardcoded value, so not sure if this issue is relevant. |
|
Does it make sense to close with a Concerns privacy label? |
The fact that it isn't dynamic severely limits its usefulness. |
Its not a technical issue, WebKit has made a conscious choice to incorrectly implement these values. In the name of "fingerprinting" protection. My opinion is just treat it as supported and if WebKit users get a worse UX then so be it. Its not vital that stuff is the right colour really. Having said that I would agree that it should just be implemented properly. |
There seems to be some confusion in that thread about how visited link colors work. It's not the same situation. What UAs do is lying about :visited state, not magically changing the value of the For context, WebKit used to return the system accent color in webkit-focus-ring-color until WebKit/WebKit@04c640b. The way of preventing fingerprinting for system colors is just returning a fixed color like WebKit does. Firefox has code for that too, for Tor. Doing something more complex would prevent using these in things like color-mix or so on. Returning a fixed color is a trade off that the browser can and should be able to make, and I'd rather avoid doing something weirder just for this (and have no idea how that would look like). |
|
I think that WebKit implements these values in a way that is allowed by the specification. I guess the request is whether we want to support them in a different manner? I think as @nt1m explained we would not be comfortable with that, but I'm not sure if marking this as "position: oppose" therefore would be reasonable. That might lead to some further misunderstanding. |
I guess that depends on interpretation. For example, the spec says:
If the system, at no point displays either If the agent isn't able to express the system color, then I rather it doesn't. In other words, I rather detect if the agent is capable of giving me an accent system color and if not, then allow the user to select one. I rather have a grayed out option to use the system color based on A mockup: |
Yeah I think the above comment sums up my thoughts. I would much rather it just not be implemented than be implemented and it not actually work. If WebKit don't believe the benefits outweigh the downsides then that's their choice but I think that should be reflected with an oppose position here and preferably it not being exposed at all. |
Given that we seem to reach different conclusions reading the same specification I opted to file w3c/csswg-drafts#9373. I don't think it's possible however to do as you wish, at this point in time user agents are expected to support system colors and not supporting them would result in websites not working correctly. |
This resolution makes the AccentColor keyword a fair bit more useful w3c/csswg-drafts#5900 (comment) |
Request for position on an emerging web specification
Information about the specification
Design reviews and vendor positions
Mozilla has shipped to stable release
Bugs tracking this feature
Anything else we need to know
These would add a standard way to access accent color information that's already exposed through prefixed properties such as
-webkit-focus-ring-color
.The text was updated successfully, but these errors were encountered: