From 693e6340aa0325ac6e6ba6cf96fce65ff61cc608 Mon Sep 17 00:00:00 2001 From: Sam Firke Date: Wed, 31 Jul 2024 11:02:40 -0400 Subject: [PATCH] chore(docs): remove mention of MariaDB in dev environment setup (#29790) Co-authored-by: Evan Rusackas --- .github/workflows/superset-docs-verify.yml | 21 +++++++++++++++++++-- docs/docs/contributing/development.mdx | 2 +- 2 files changed, 20 insertions(+), 3 deletions(-) diff --git a/.github/workflows/superset-docs-verify.yml b/.github/workflows/superset-docs-verify.yml index 1f32c00d7bd66..0b5588342b55e 100644 --- a/.github/workflows/superset-docs-verify.yml +++ b/.github/workflows/superset-docs-verify.yml @@ -13,6 +13,7 @@ concurrency: jobs: linkinator: + # See docs here: https://github.com/marketplace/actions/linkinator name: Link Checking runs-on: ubuntu-latest steps: @@ -20,8 +21,24 @@ jobs: - uses: JustinBeckwith/linkinator-action@v1.10.4 with: paths: "**/*.md, **/*.mdx" - linksToSkip: '^https://github.com/apache/(superset|incubator-superset)/(pull|issue)/\d+, http://localhost:8088/, docker/.env-non-dev, http://127.0.0.1:3000/, http://localhost:9001/, https://charts.bitnami.com/bitnami, https://www.li.me/, https://www.fanatics.com/, https://tails.com/gb/, https://www.techaudit.info/, https://avetilearning.com/, https://www.udemy.com/, https://trustmedis.com/, http://theiconic.com.au/, https://dev.mysql.com/doc/refman/5.7/en/innodb-limits.html, https://img.shields.io/librariesio/release/npm/%40superset-ui%2Fembedded-sdk?style=flat, https://img.shields.io/librariesio/release/npm/%40superset-ui%2Fplugin-chart-pivot-table?style=flat, https://vkusvill.ru/' - # verbosity: 'ERROR' + linksToSkip: >- + ^https://github.com/apache/(superset|incubator-superset)/(pull|issue)/\d+, + http://localhost:8088/, + docker/.env-non-dev, + http://127.0.0.1:3000/, + http://localhost:9001/, + https://charts.bitnami.com/bitnami, + https://www.li.me/, + https://www.fanatics.com/, + https://tails.com/gb/, + https://www.techaudit.info/, + https://avetilearning.com/, + https://www.udemy.com/, + https://trustmedis.com/, + http://theiconic.com.au/, + https://dev.mysql.com/doc/refman/5.7/en/innodb-limits.html, + ^https://img\.shields\.io/.*, + https://vkusvill.ru/ build-deploy: name: Build & Deploy runs-on: ubuntu-22.04 diff --git a/docs/docs/contributing/development.mdx b/docs/docs/contributing/development.mdx index 1081f439f709b..900b62efb0986 100644 --- a/docs/docs/contributing/development.mdx +++ b/docs/docs/contributing/development.mdx @@ -108,7 +108,7 @@ functioning across environments. #### OS Dependencies Make sure your machine meets the [OS dependencies](https://superset.apache.org/docs/installation/pypi#os-dependencies) before following these steps. -You also need to install MySQL or [MariaDB](https://mariadb.com/downloads). +You also need to install MySQL. Ensure that you are using Python version 3.9, 3.10 or 3.11, then proceed with: