Template review feedback

[praveena-pappu]

Thanks for submitting a template to the gallery, there were a few issues in your template that needed to be resolved ahead of approving the template for the gallery.

1. encodeUriComponent should be used on user provided values that are then used as parameters in your url. These methods take in a single text argument and return a URI Encoded string. You should use this method on 'account' and 'page' when generating the url
   const url = 'https://'+host + '/fcgi-bin/dispatch.fcgi?a.A=co&a.si=' + account + 'a.co=' + page;
2. encodeUri should be used on user provided values. It returns an encoded Uniform Resource Identifier (URI) by escaping special characters and a string that represents the provided string encoded as a URI. You should use this method on 'host' when generating the url
   const url = 'https://'+host + '/fcgi-bin/dispatch.fcgi?a.A=co&a.si=' + account + 'a.co=' + page;
3. We are seeing "A service error has occurred. Please try again later." error when we did test run. Please resolve the issue.
   

[etc-crontab]

Hello @praveena-pappu,

Thanks for the review. The 2 first errors you mentioned have been fixed, but the 3rd one appears to be a 500 error received when POSTing a call to https://tagmanager.google.com/api/accounts/xxx/containers/yyy/workspaces/3/vteditor/preview.
There is no indication on what the issue is on our side, and as the server returns a 500 error, there is no helpful message to try to fix the issue. The added test pass, the call is visible on the 'Network' tab of the developer toolbar, but when clicking on "Run Code" on the "Code" tab, there is a 500 error.
Can you please help on this matter?

[praveena-pappu]

Thanks for submitting a template to the gallery, there were a few issues in your template that needed to be resolved ahead of approving the template for the gallery.

1. encodeUriComponent should be used on user provided values that are then used as parameters in your url. These methods take in a single text argument and return a URI Encoded string. You should use this method on 'account' and 'page' when generating the url
   const url = 'https://'+host + '/fcgi-bin/dispatch.fcgi?a.A=co&a.si=' + account + '&a.co=' + page + '&g.r=' + rnd;

[etc-crontab]

@praveena-pappu the template has been updated few weeks ago with the encoding of the variables. Can you please tell me if it is correct now?

[etc-crontab]

@praveena-pappu the template has been updated once again, the "A service error has occurred. Please try again later." message has been fixed. Can you please check it?